Adding feature toggles to the customization menu

I'm having trouble adding toggles to my EXE so that the player can manually disable certain features at their leisure.

Specifically, I need to add a toggle so that the player can disable the shading within the menu.

Anyone got some tips to help me out?

The Wolf3D menu is difficult to work with so don't expect these changes to work out of the box.

Code:

diff a/foreign.h b/foreign.h
index 66c0bb7..49400e6 100755
--- a/foreign.h
+++ b/foreign.h
@@ -50,6 +50,7 @@
 #define   STR_GAMEPAD   "Gravis GamePad Enabled"
 #define   STR_SENS   "Mouse Sensitivity"
 #define   STR_CUSTOM   "Customize controls"
+#define   STR_SHADING   "Shading"
 
 //#define   STR_DADDY   "Can I play, Daddy?"
 //#define   STR_HURTME   "Don't hurt me."
diff a/wl_menu.cpp b/wl_menu.cpp
index c9f774f..bbc4c97 100755
--- a/wl_menu.cpp
+++ b/wl_menu.cpp
@@ -134,7 +134,7 @@ CP_itemtype SndMenu[] = {
 #endif
 };
 
-enum { CTL_MOUSEENABLE, CTL_MOUSESENS, CTL_JOYENABLE, CTL_CUSTOMIZE };
+enum { CTL_MOUSEENABLE, CTL_MOUSESENS, CTL_JOYENABLE, CTL_CUSTOMIZE, CTL_SHADING };
 
 CP_itemtype CtlMenu[] = {
 #ifdef JAPAN
@@ -142,11 +142,13 @@ CP_itemtype CtlMenu[] = {
    {0, "", MouseSensitivity},
    {0, "", 0},
    {1, "", CustomControls}
+    {1, "", 0}
 #else
    {0, STR_MOUSEEN, 0},
    {0, STR_SENS, MouseSensitivity},
    {0, STR_JOYEN, 0},
-    {1, STR_CUSTOM, CustomControls}
+    {1, STR_CUSTOM, CustomControls},
+    {1, STR_SHADING, 0}
 #endif
 };
 
@@ -2094,6 +2096,13 @@ CP_Control (int)
                MenuFadeIn ();
                WaitKeyUp ();
                break;
+
+            case CTL_SHADING:
+                shadingenabled ^= 1;
+                DrawCtlScreen ();
+                CusItems.curpos = -1;
+                ShootSnd ();
+                break;
        }
    }
    while (which >= 0);
@@ -2280,6 +2289,13 @@ DrawCtlScreen (void)
    else
        VWB_DrawPic (x, y, C_NOTSELECTEDPIC);
 
+    x = CTL_X + CtlItems.indent - 24;
+    y = CTL_Y + 40; // LinuxWolf: 40 will need to be adjusted to something else
+    if (shadingenabled)
+        VWB_DrawPic (x, y, C_SELECTEDPIC);
+    else
+        VWB_DrawPic (x, y, C_NOTSELECTEDPIC);
+
    //
    // PICK FIRST AVAILABLE SPOT
    //


Well I did what you said to do and going from there I was able to enable the feature I wanted, however I have a few more bugs that have arisen that I need help with (they're on this subject, so I'll post them here).

A picture for clarity:

Anyways, the bugs should be apparent right away.
First, the shading tab is outside of the controls selection box (and the cursor will go outside that box as well, causing further image distortion).
And second, the Light that signifies of the shading tab is active or deactive is next to the Control customization tab instead of the shading tab.

I need to fix both of these, but I'm also going to be adding another controls menu, so I need to extend the dark green box surroudning the menu items so that there is room for another item (this one, placed directly below the Customize Controls tab, and above the Shading Toggle which will be located at the bottom of the menu altogether).


Here's the code for my DrawCtlScreen:

Code:

void
DrawCtlScreen (void)
{
    int i, x, y;

#ifdef JAPAN
    CA_CacheScreen (S_CONTROLPIC);
#else
    ClearMScreen ();
    DrawStripes (10);
    VWB_DrawPic (80, 0, C_CONTROLPIC);
    VWB_DrawPic (112, 184, C_MOUSELBACKPIC);
    DrawWindow (CTL_X - 8, CTL_Y - 5, CTL_W, CTL_H, BKGDCOLOR);
#endif
    WindowX = 0;
    WindowW = 320;
    SETFONTCOLOR (TEXTCOLOR, BKGDCOLOR);

    if (IN_JoyPresent())
        CtlMenu[CTL_JOYENABLE].active = 1;

    if (MousePresent)
    {
        CtlMenu[CTL_MOUSESENS].active = CtlMenu[CTL_MOUSEENABLE].active = 1;
    }

    CtlMenu[CTL_MOUSESENS].active = mouseenabled;


    DrawMenu (&CtlItems, CtlMenu);


    x = CTL_X + CtlItems.indent - 32;//24;
    y = CTL_Y + 3;
    if (mouseenabled)
        VWB_DrawPic (x, y, C_SELECTEDPIC);
    else
        VWB_DrawPic (x, y, C_NOTSELECTEDPIC);

    y = CTL_Y + 29;
    if (joystickenabled)
        VWB_DrawPic (x, y, C_SELECTEDPIC);
    else
        VWB_DrawPic (x, y, C_NOTSELECTEDPIC);

    //x = CTL_X + CtlItems.indent - 24;
    y = CTL_Y + 40; // LinuxWolf: 40 will need to be adjusted to something else
    if (shadingenabled)
        VWB_DrawPic (x, y, C_SELECTEDPIC);
    else
        VWB_DrawPic (x, y, C_NOTSELECTEDPIC);

    //
    // PICK FIRST AVAILABLE SPOT
    //
    if (CtlItems.curpos < 0 || !CtlMenu[CtlItems.curpos].active)
    {
        for (i = 0; i < CtlItems.amount; i++)
        {
            if (CtlMenu[i].active)
            {
                CtlItems.curpos = i;
                break;
            }
        }
    }

    DrawMenuGun (&CtlItems);
    VW_UpdateScreen ();
}

Can anyone help me with this? I'd be immensely greatful.

Adjust this line in wl_menu.h line 86 (approx) to fix shading tab and cursor outside the controls selection box:

#define CTL_H 60

Increase this value from 60 to, say, 80 and see if the box is big enough to contain all items and cursor.

Also adjust this line in wl_menu.cpp line 4385 (approx):

y = CTL_Y + 40; // LinuxWolf: 40 will need to be adjusted to something else
if (shadingenabled)

The number 40 needs to be adjusted to make the cursor appear at the correct spot. I already added a comment to the end of that line as a hint.

Alright, thanks for the help. I got the whole thing to work properly now.